[DFDL-WG] Contributing to github
Bradd Kadlecik
braddk at us.ibm.com
Wed Mar 3 14:42:25 EST 2021
I have not looked at TDML before but it does look interesting. I'm sure
the z/TPF DFDL parser will likely need a way to use this in the future so
that we can validate the behavior. Having an expected binary output for
pointers does present a problem but the way I'd likely try to do it is by
using something we've started using internally. We have tooling that runs
an unparse with JSON, XML, BSON, etc as input and creates a binary file.
We also can run a parse using a binary file as input to create whatever
document format desired. With pointer support this didn't work of course
so we made a simple routine in the parser that can create a contiguous blob
that exchanges all pointer addresses for offsets. This is called before
filing out the binary. When reading in the binary we can call another
routine that exchanges all offsets with the pointer address. There's an
internal switch to treat all pointers as offsets when either creating the
infoset or when creating the data stream from it. This may also be a
function users find useful to be able to file down such data and then use
it again after reading it back in.
In the end this isn't really validating the pointer data but the behavior
between offsets and pointers should be fairly consistent.
Regards,
Bradd Kadlecik
z/TPF Development
Phone: 1-845-433-1573 2455 South Rd
E-mail: braddk at us.ibm.com Poughkeepsie, NY
12601-5400
United States
From: Mike Beckerle <mbeckerle.dfdl at gmail.com>
To: Bradd Kadlecik <braddk at us.ibm.com>
Cc: DFDL-WG <dfdl-wg at ogf.org>, Steve Hanson <smh at uk.ibm.com>
Date: 03/03/2021 10:43 AM
Subject: [EXTERNAL] Re: Contributing to github
I merged your PR - squashed the 5 commits into one, so that the document
appears to be just added. You can delete the branch if you want, or keep
for future use. I was thinking about implementing this feature recently,
and I am trying to come
I merged your PR - squashed the 5 commits into one, so that the document
appears to be just added.
You can delete the branch if you want, or keep for future use.
I was thinking about implementing this feature recently, and I am trying to
come up with a test rig for it.
I'd like to somehow adapt the TDML test language to support testing these
concepts in some uniform way where we can all agree on
what the results of a test should be, and exchange such tests.
I think you have to be able to define multiple data "documents" in the TDML
test case, and arrange for the "address" of each of them to be somehow
embeddable in other ones to form a tree of pointed-to data blocks.
Offsets will be easier, as you can do it all in the same single data
document.
I'm curious what you can share about how to test Brad.
Thoughts?
Mike Beckerle | OGF DFDL Workgroup Co-Chair | Owl Cyber Defense |
www.owlcyberdefense.com
Please note: Contributions to the DFDL Workgroup's email discussions are
subject to the OGF Intellectual Property Policy
On Thu, Feb 18, 2021 at 5:45 PM Bradd Kadlecik <braddk at us.ibm.com> wrote:
Sounds good. Thanks for the explanation as this is my first time with
git. I'll submit the PR.
Regards,
Bradd
Kadlecik
z/TPF
Development
Phone: 2455 South Rd
1-845-433-1573 Poughkeepsie,
E-mail: NY 12601-5400
braddk at us.ibm.com United States
Inactive hide details for Mike Beckerle ---02/18/2021 04:51:09 PM---The
right workflow for git is always a discussion, but partMike Beckerle
---02/18/2021 04:51:09 PM---The right workflow for git is always a
discussion, but particularly when dealing with binary documen
From: Mike Beckerle <mbeckerle.dfdl at gmail.com>
To: Bradd Kadlecik <braddk at us.ibm.com>
Cc: DFDL-WG <dfdl-wg at ogf.org>, Steve Hanson <smh at uk.ibm.com>
Date: 02/18/2021 04:51 PM
Subject: [EXTERNAL] Re: Contributing to github
The right workflow for git is always a discussion, but particularly...
This
Mess
age
Is
From
an
Exte
rnal
Send
er
This
mess
age
came
from
outs
ide
your
orga
niza
tion
.
The right workflow for git is always a discussion, but particularly when
dealing with binary document formats that github provides no delta
support for.
The PR suggests your intention to contribute the document. I think this
is a good thing to do now. At minimum it prods us with emails that there
is a thing to review and that you've requested that review.
A reviewer would pull your branch, check out, review the document, adding
MS-word comments to it internally, then push the changes back to that
same branch.
At some point the PR gets approved (ie, no unresolved comments, or
comments are issues we agree to keep open.) and merged, and the branch
deleted.
Is that an ok workflow?
Mike Beckerle | OGF DFDL Workgroup Co-Chair | Owl Cyber Defense |
www.owlcyberdefense.com
Please note: Contributions to the DFDL Workgroup's email discussions are
subject to the OGF Intellectual Property Policy
On Thu, Feb 18, 2021 at 2:54 PM Bradd Kadlecik <braddk at us.ibm.com> wrote:
Thanks, added gwde-dfdl-experience-8-v0.1.docx to working-drafts in
indirection-draft branch. I assume I should wait for review before
submitting pull request.
Regards,
Bradd
Kadlecik
z/TPF
Development
Phone: 2455 South Rd
1-845-433-1573 Poughkeepsie,
E-mail: NY 12601-5400
braddk at us.ibm.com United States
Inactive hide details for Mike Beckerle ---02/18/2021 02:39:28
PM---Bradd, You should get an invite to be a contributor to theMike
Beckerle ---02/18/2021 02:39:28 PM---Bradd, You should get an
invite to be a contributor to the repo. I've added you
From: Mike Beckerle <mbeckerle.dfdl at gmail.com>
To: Bradd Kadlecik <braddk at us.ibm.com>
Cc: Steve Hanson <smh at uk.ibm.com>, DFDL-WG <dfdl-wg at ogf.org>
Date: 02/18/2021 02:39 PM
Subject: [EXTERNAL] Re: Contributing to github
Bradd, You should get an invite to be a contributor to the repo....
This
Mess
age
Is
From
an
Exte
rnal
Send
er
This
mess
age
came
from
outs
ide
your
orga
niza
tion
.
Bradd,
You should get an invite to be a contributor to the repo. I've
added you with write access.
Mike Beckerle | OGF DFDL Workgroup Co-Chair | Owl Cyber Defense |
www.owlcyberdefense.com
Please note: Contributions to the DFDL Workgroup's email
discussions are subject to the OGF Intellectual Property Policy
On Thu, Feb 18, 2021 at 2:31 PM Bradd Kadlecik <braddk at us.ibm.com>
wrote:
Hi,
I was unable to create a branch in github to upload the
experience document for indirection. My userid there is
tpfbraddk.
Regards,
Bradd
Kadlecik
z/TPF
Development
Phone: 2455 South Rd
1-845-433-1573 Poughkeepsie,
E-mail: NY 12601-5400
braddk at us.ibm.com United States
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.ogf.org/pipermail/dfdl-wg/attachments/20210303/4104a3c0/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: graycol.gif
Type: image/gif
Size: 105 bytes
Desc: not available
URL: <http://www.ogf.org/pipermail/dfdl-wg/attachments/20210303/4104a3c0/attachment-0001.gif>
More information about the dfdl-wg
mailing list